search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

feat: Add user prefs for subtitles+cc lang, including local storage. #770

Closed cjpillsbury closed 11 months ago

cjpillsbury commented 1 year ago

Preview: https://media-chrome-git-fork-cjpillsbury-feat-media-lang-su-7022a5-mux.vercel.app/examples/vanilla/control-elements/media-captions-selectmenu.html

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 9:06pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 9:06pm
vercel[bot] commented 1 year ago

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (893b826) 78.88% compared to head (fede7d8) 78.07%. Report is 2 commits behind head on main.

Files Patch % Lines
src/js/controller.js 8.47% 54 Missing :warning:
src/js/experimental/media-captions-listbox.js 45.83% 13 Missing :warning:
src/js/media-controller.js 7.69% 12 Missing :warning:
src/js/media-captions-button.js 45.45% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #770 +/- ## ========================================== - Coverage 78.88% 78.07% -0.82% ========================================== Files 58 58 Lines 10552 10599 +47 ========================================== - Hits 8324 8275 -49 - Misses 2228 2324 +96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.