muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

fix: video element memory leak + optimizations #775

Closed luwes closed 11 months ago

luwes commented 11 months ago

fixes #750

vercel[bot] commented 11 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ebb4f15) 78.07% compared to head (92f8d54) 78.67%.

Files Patch % Lines
src/js/media-container.js 89.09% 6 Missing :warning:
src/js/media-controller.js 97.72% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #775 +/- ## ========================================== + Coverage 78.07% 78.67% +0.60% ========================================== Files 58 58 Lines 10599 10627 +28 ========================================== + Hits 8275 8361 +86 + Misses 2324 2266 -58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luwes commented 11 months ago

ha! I put the track elements back in and the memory leak is back... digging

            <track
              label="thumbnails"
              default
              kind="metadata"
              src="https://image.mux.com/DS00Spx1CV902MCtPj5WknGlR102V5HFkDe/storyboard.vtt"
            />
            <track
              label="English"
              kind="captions"
              srcLang="en"
              src="./vtt/en-cc.vtt"
            />
vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 5:36pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 5:36pm