muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.21k stars 62 forks source link

Feat/default duration #779

Closed cjpillsbury closed 9 months ago

cjpillsbury commented 9 months ago

Adds support for defaultduration to apply before media is loaded.

NOTE: The <media-time-range> can still be interacted with before the media has loaded, but that was already true.

vercel[bot] commented 9 months ago

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 9:16pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 9:16pm
codecov[bot] commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e1d6377) 78.67% compared to head (feddaf9) 78.65%. Report is 2 commits behind head on main.

:exclamation: Current head feddaf9 differs from pull request most recent head fe30917. Consider uploading reports for the commit fe30917 to get more accurate results

Files Patch % Lines
src/js/controller.js 60.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #779 +/- ## ========================================== - Coverage 78.67% 78.65% -0.03% ========================================== Files 58 58 Lines 10627 10644 +17 ========================================== + Hits 8361 8372 +11 - Misses 2266 2272 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.