Closed cjpillsbury closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
media-chrome | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 28, 2024 8:51pm |
media-chrome-demo-nextjs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 28, 2024 8:51pm |
media-chrome-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 28, 2024 8:51pm |
Attention: Patch coverage is 83.17207%
with 400 lines
in your changes are missing coverage. Please review.
Project coverage is 80.45%. Comparing base (
3ea80df
) to head (8255641
). Report is 13 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- all (many) menu examples w/ external controller are broken
yeah this was another refactor since the last update 💔 let me investigate here.
To-dos from an IRL convo yesterday w/ @cjpillsbury and @AdamJaggard .
@heff + @luwes just a heads up: I gutted all of the react-specific src and examples from this branch to get it in approximately "final form" for a v1 merge. I still have those in a branch locally for any v2+ efforts though.
@cjpillsbury let me know if you're waiting on anything from me on this one.
@heff since this is a larger refactor, I would like to get folks doing a bunch of before/after smoke tests before merging. I'll also need to re-rebase based on some recent changes, including at least one that touches on media state.
@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.
A member of the Team first needs to authorize it.