muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

Feat/media store rearchitecture #784

Closed cjpillsbury closed 8 months ago

vercel[bot] commented 10 months ago

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 8:51pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 8:51pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 8:51pm
codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 83.17207% with 400 lines in your changes are missing coverage. Please review.

Project coverage is 80.45%. Comparing base (3ea80df) to head (8255641). Report is 13 commits behind head on main.

Files Patch % Lines
src/js/media-store/state-mediator.js 79.38% 247 Missing :warning:
src/js/media-controller.js 67.83% 46 Missing :warning:
src/js/media-store/request-map.js 84.47% 43 Missing :warning:
src/js/media-store/util.js 66.95% 38 Missing :warning:
src/js/media-store/media-store.js 95.81% 24 Missing :warning:
src/js/utils/element-utils.js 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #784 +/- ## ========================================== + Coverage 78.55% 80.45% +1.90% ========================================== Files 59 62 +3 Lines 11080 12240 +1160 ========================================== + Hits 8704 9848 +1144 - Misses 2376 2392 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cjpillsbury commented 10 months ago
  • all (many) menu examples w/ external controller are broken

yeah this was another refactor since the last update 💔 let me investigate here.

heff commented 9 months ago

To-dos from an IRL convo yesterday w/ @cjpillsbury and @AdamJaggard .

cjpillsbury commented 9 months ago

@heff + @luwes just a heads up: I gutted all of the react-specific src and examples from this branch to get it in approximately "final form" for a v1 merge. I still have those in a branch locally for any v2+ efforts though.

heff commented 9 months ago

@cjpillsbury let me know if you're waiting on anything from me on this one.

cjpillsbury commented 9 months ago

@heff since this is a larger refactor, I would like to get folks doing a bunch of before/after smoke tests before merging. I'll also need to re-rebase based on some recent changes, including at least one that touches on media state.