Closed luwes closed 10 months ago
@luwes is attempting to deploy a commit to the Mux Team on Vercel.
A member of the Team first needs to authorize it.
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
aa24858
) 78.72% compared to head (934f271
) 78.63%.
Files | Patch % | Lines |
---|---|---|
src/js/utils/element-utils.js | 53.33% | 21 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
media-chrome | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 9, 2024 8:08pm |
media-chrome-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 9, 2024 8:08pm |
select
/listbox
/option
pattern tomenu
/menuitem
patterninvoketarget
attribute and auto linking between x-menu-button & x-menu elementsanchor
attribute or auto linkingselectmenu
to make the connection between button and menu. this improves flexibility, less elements. it's with new upcoming / proposed API's in mind that promote this concept. https://developer.mozilla.org/en-US/docs/Web/API/Popover_API https://open-ui.org/components/invokers.explainer/ https://www.w3.org/TR/css-anchor-position-1/ https://developer.chrome.com/blog/tether-elements-to-each-other-with-css-anchor-positioningI propose to make this connection automatically for ease of use, less HTML needed but it can be made explicit with the
invoketarget
<->id
attributes oranchor
<->id
for the positioning.example of an automatic connection:
this menu captions button will automatically open the captions menu because the button finds a valid target. if there is no menu it falls back to the default behavior.
the captions menu is also automatically anchored to the captions menu button position as this is the most common behavior. it will be possible to opt out with
anchor=""
or similar.