Closed luwes closed 9 months ago
@luwes is attempting to deploy a commit to the Mux Team on Vercel.
A member of the Team first needs to authorize it.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a62a34a
) 78.63% compared to head (0bb1118
) 78.63%.:exclamation: Current head 0bb1118 differs from pull request most recent head 2663880. Consider uploading reports for the commit 2663880 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
media-chrome | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 1, 2024 5:07pm |
media-chrome-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 1, 2024 5:07pm |
If you open a sub-menu and then resize the player the sub menu bleeds out of the player
If you open a sub-menu and then resize the player the sub menu bleeds out of the player
this one should be fixed
test URL: https://media-chrome-git-fork-luwes-settings-menu-mux.vercel.app/examples/vanilla/control-elements/media-settings-menu.html
this change adds new settings-menu and settings-menu-item elements and logic to handle submenus with customizable headers, back button, chevron icons, etc...
the case of a settings-menu in another settings-menu is not yet tried or implemented, it's a more rare case I'd like to add later.
the settings-menu-item has a
description
slot which automatically gets populated with the submenu checked item text. it's possible for the developer to opt-out by setting a slotted description element.all icons can be customized with slots, the headers of the menu can be customized with a slot or just the title keeping the back button intact.