muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

feat: add settings-menu #788

Closed luwes closed 9 months ago

luwes commented 10 months ago

test URL: https://media-chrome-git-fork-luwes-settings-menu-mux.vercel.app/examples/vanilla/control-elements/media-settings-menu.html

SCR-20240124-mvrg

this change adds new settings-menu and settings-menu-item elements and logic to handle submenus with customizable headers, back button, chevron icons, etc...

the case of a settings-menu in another settings-menu is not yet tried or implemented, it's a more rare case I'd like to add later.

the settings-menu-item has a description slot which automatically gets populated with the submenu checked item text. it's possible for the developer to opt-out by setting a slotted description element.

all icons can be customized with slots, the headers of the menu can be customized with a slot or just the title keeping the back button intact.

vercel[bot] commented 10 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a62a34a) 78.63% compared to head (0bb1118) 78.63%.

:exclamation: Current head 0bb1118 differs from pull request most recent head 2663880. Consider uploading reports for the commit 2663880 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #788 +/- ## ======================================= Coverage 78.63% 78.63% ======================================= Files 58 58 Lines 10782 10782 ======================================= Hits 8478 8478 Misses 2304 2304 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 5:07pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 5:07pm
AdamJaggard commented 9 months ago

If you open a sub-menu and then resize the player the sub menu bleeds out of the player

image
luwes commented 9 months ago

If you open a sub-menu and then resize the player the sub menu bleeds out of the player

image

this one should be fixed