search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

fix: add way to hide menuitems w/ unfilled submenu #801

Closed luwes closed 9 months ago

luwes commented 9 months ago

adds a way to hide a menu item based on the size of the submenu items

      media-settings-menu-item[aria-haspopup]:is(
        :not([submenusize]),
        [submenusize="0"],
        [submenusize="1"]
      ) {
        display: none;
      }
vercel[bot] commented 9 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 8:15pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 8:15pm
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dbc79eb) 78.64% compared to head (c5c3638) 78.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #801 +/- ## ======================================= Coverage 78.64% 78.64% ======================================= Files 58 58 Lines 10789 10789 ======================================= Hits 8485 8485 Misses 2304 2304 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.