search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.21k stars 62 forks source link

fix: access sheet before connected to DOM #813

Closed luwes closed 7 months ago

luwes commented 7 months ago

same than the previous bug fix.

good it uncovered some more issues that are related to trying to access a style sheet before connected to the DOM which seems not possible.

we still keep the dummy CSSStyleRule in the return to not have type errors but I added a warning and a comment to indicate there might be an issue in the code.

vercel[bot] commented 7 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 0:44am
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 0:44am
codecov[bot] commented 7 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9f119fc) 78.54% compared to head (f20be47) 78.50%. Report is 2 commits behind head on main.

Files Patch % Lines
src/js/utils/element-utils.js 0.00% 4 Missing :warning:
src/js/media-loading-indicator.js 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #813 +/- ## ========================================== - Coverage 78.54% 78.50% -0.05% ========================================== Files 59 59 Lines 11093 11094 +1 ========================================== - Hits 8713 8709 -4 - Misses 2380 2385 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.