search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.21k stars 62 forks source link

fix: poster slot fade after play before playing #824

Closed luwes closed 7 months ago

luwes commented 7 months ago

fix #823

vercel[bot] commented 7 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (3ea80df) 78.55% compared to head (26fc77e) 78.44%. Report is 5 commits behind head on main.

Files Patch % Lines
src/js/controller.js 33.33% 18 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #824 +/- ## ========================================== - Coverage 78.55% 78.44% -0.12% ========================================== Files 59 59 Lines 11080 11104 +24 ========================================== + Hits 8704 8710 +6 - Misses 2376 2394 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 2:33pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 2:33pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 2:33pm
cjpillsbury commented 7 months ago

Per @luwes's advice: before/after smoke tested using

Using dev tools, disabled cache and throttled network to slow 3g. Once controls rendered, attempted to play using play button.