muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.21k stars 62 forks source link

Docs/react media store #880

Closed cjpillsbury closed 5 months ago

cjpillsbury commented 5 months ago
vercel[bot] commented 5 months ago

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 4:47pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 4:47pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 4:47pm
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 94.85714% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 72.53%. Comparing base (3ea80df) to head (ab50132). Report is 54 commits behind head on main.

:exclamation: Current head ab50132 differs from pull request most recent head b02f704. Consider uploading reports for the commit b02f704 to get more accurate results

Files Patch % Lines
src/js/media-store/state-mediator.js 89.65% 6 Missing :warning:
src/js/media-store/request-map.js 80.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #880 +/- ## ========================================== - Coverage 78.55% 72.53% -6.02% ========================================== Files 59 79 +20 Lines 11080 15581 +4501 ========================================== + Hits 8704 11302 +2598 - Misses 2376 4279 +1903 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luwes commented 5 months ago

not sure if it's an easy fix but could the 2nd column be made more wide, in a few tables they look squished

SCR-20240411-kesi
cjpillsbury commented 5 months ago

not sure if it's an easy fix but could the 2nd column be made more wide, in a few tables they look squished

@luwes Yeah I didn't see any way to resolve that quickly, but if you find something, keep me posted.