search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.21k stars 62 forks source link

feat!: Tooltips #941

Closed AdamJaggard closed 1 month ago

AdamJaggard commented 2 months ago

Adds a new media-tooltip element and includes tooltips by default in anything that extends the media-chrome-button class. Tooltips can be placed either top, right, bottom, left or none.

fix #411 related #933

vercel[bot] commented 2 months ago

@AdamJaggard is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 2:32pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 2:32pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 2:32pm
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.35993% with 45 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (3ea80df) to head (a8665e0). Report is 75 commits behind head on main.

Files Patch % Lines
src/js/media-tooltip.ts 94.66% 15 Missing :warning:
src/js/media-chrome-button.ts 94.89% 5 Missing :warning:
src/js/media-playback-rate-menu-button.ts 50.00% 5 Missing :warning:
src/js/media-seek-backward-button.ts 16.66% 5 Missing :warning:
src/js/media-seek-forward-button.ts 16.66% 5 Missing :warning:
src/js/media-airplay-button.ts 96.00% 1 Missing :warning:
src/js/media-audio-track-menu-button.ts 85.71% 1 Missing :warning:
src/js/media-captions-menu-button.ts 83.33% 1 Missing :warning:
src/js/media-cast-button.ts 93.75% 1 Missing :warning:
src/js/media-fullscreen-button.ts 96.00% 1 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #941 +/- ## ========================================== - Coverage 78.55% 70.55% -8.01% ========================================== Files 59 80 +21 Lines 11080 17088 +6008 Branches 0 861 +861 ========================================== + Hits 8704 12056 +3352 - Misses 2376 5013 +2637 - Partials 0 19 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.