search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

fix: floating time display position #942

Closed luwes closed 4 months ago

luwes commented 4 months ago

found a bug when the preview thumbnail is sufficiently big, the time display will stay centered and the arrow underneath will stay positioned anchored to the cursor.

this change makes it so the time display will float together with the arrow until it reaches the limit of the bounding box.

vercel[bot] commented 4 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:57pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:57pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:57pm
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.75%. Comparing base (3ea80df) to head (886f89b). Report is 73 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #942 +/- ## ========================================== - Coverage 78.55% 69.75% -8.80% ========================================== Files 59 79 +20 Lines 11080 16572 +5492 Branches 0 842 +842 ========================================== + Hits 8704 11560 +2856 - Misses 2376 4993 +2617 - Partials 0 19 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.