search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.21k stars 62 forks source link

fix: add small TS fixes + improvements #943

Closed luwes closed 2 months ago

luwes commented 2 months ago

found by building mux-player

vercel[bot] commented 2 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:01pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:01pm
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 69.75%. Comparing base (3ea80df) to head (6360766). Report is 73 commits behind head on main.

Files Patch % Lines
src/js/media-audio-track-menu.ts 0.00% 2 Missing :warning:
src/js/media-chrome-menu.ts 0.00% 2 Missing :warning:
src/js/media-playback-rate-menu.ts 0.00% 2 Missing :warning:
src/js/media-rendition-menu.ts 0.00% 2 Missing :warning:
src/js/media-settings-menu.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #943 +/- ## ========================================== - Coverage 78.55% 69.75% -8.80% ========================================== Files 59 79 +20 Lines 11080 16573 +5493 Branches 0 842 +842 ========================================== + Hits 8704 11561 +2857 - Misses 2376 4993 +2617 - Partials 0 19 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.