search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.21k stars 62 forks source link

Add seektoliveoffset attribute #958

Open k-g-a opened 1 month ago

k-g-a commented 1 month ago
  1. Implements https://github.com/muxinc/media-chrome/issues/923, adds documentation (with motivation).
  2. Fixes a regression of noautoseektolive not being used at all
  3. Fixes a couple of broken links in docs.
vercel[bot] commented 1 month ago

@k-g-a is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

luwes commented 1 week ago

thank you for the contribution! I'll bring this up with the team.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 57.40741% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.94%. Comparing base (3ea80df) to head (3ba89cd). Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
src/js/media-controller.ts 29.62% 19 Missing :warning:
src/js/media-store/request-map.ts 73.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #958 +/- ## ========================================== + Coverage 78.55% 78.94% +0.38% ========================================== Files 59 50 -9 Lines 11080 12101 +1021 Branches 0 771 +771 ========================================== + Hits 8704 9553 +849 - Misses 2376 2548 +172 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

k-g-a commented 4 days ago

Hi, @luwes!

I'd like to fix the coverage issue of this PR, but, unfortunatelly, I could not find any examples of working with live streams in test cases. So I'm open to ideas/suggestions to implement.