search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.83k stars 76 forks source link

fix: NaN valueAsNumber Safari error #967

Closed luwes closed 2 months ago

luwes commented 2 months ago

fix #947

vercel[bot] commented 2 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 7:35pm
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (3ea80df) to head (116fb9f). Report is 95 commits behind head on main.

Files with missing lines Patch % Lines
src/js/media-time-range.ts 20.00% 4 Missing :warning:
src/js/media-volume-range.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #967 +/- ## ========================================== + Coverage 78.55% 79.00% +0.45% ========================================== Files 59 50 -9 Lines 11080 12057 +977 Branches 0 765 +765 ========================================== + Hits 8704 9526 +822 - Misses 2376 2531 +155 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.