search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

Buttons not rendering on 3.2.6-canary.1 onward #968

Closed streamworksaudio closed 2 months ago

streamworksaudio commented 2 months ago

I think there is a bug that starts with 3.2.6-canary.1 and up. The bug is that the media-settings-menu-button and media-captions-menu-button buttons are not rendering correctly.

They appear perfect on 3.2.6-canary.0 - but any version after that they do not show on the media-control-bar

Appears to be a bug - anybody else having this issue?

luwes commented 2 months ago

This was a change we made for v4. See https://www.media-chrome.org/docs/en/migration/from-3.x-to-4.0

They can be imported via import 'media-chrome/menu';

Menu components moved to separate import

The menu components that were included by default in v3 are now moved to a separate import. This gives you more granular control and can save some extra weight in the final JS bundle if you don’t need these components. You can import them from media-chrome/menu.