search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.83k stars 76 forks source link

fix: tooltip type error #988

Closed luwes closed 2 months ago

luwes commented 2 months ago

fix #986

vercel[bot] commented 2 months ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:12pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:12pm
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.89%. Comparing base (3ea80df) to head (93324bd). Report is 111 commits behind head on main.

Files with missing lines Patch % Lines
src/js/media-chrome-button.ts 88.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #988 +/- ## ========================================== - Coverage 78.55% 76.89% -1.67% ========================================== Files 59 50 -9 Lines 11080 12088 +1008 Branches 0 695 +695 ========================================== + Hits 8704 9295 +591 - Misses 2376 2768 +392 - Partials 0 25 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luwes commented 2 months ago

good idea. for now it's fine I think because we don't reset it anymore. we cache it right after the DOM is appended so the query will always return the media-tooltip element.