Compatibility with PHP 5.6

muxinc / mux-php

Official Mux API wrapper for PHP projects, supporting both Mux Data and Mux Video.

MIT License

40 stars 30 forks source link

Compatibility with PHP 5.6 #10

Closed jawngee closed 3 years ago

jawngee commented 4 years ago

We have the misfortune of having to support a few customers who still use 5.6. We will stop supporting it in the very near future, but until then ...

Your library is compatible with 5.6 though. I've added the polyfills just in case, but guzzle already includes most of them as well.

philcluff commented 4 years ago

Hey @jawngee

Thanks for the PR. I want to think carefully before we commit to supporting PHP 5.6 since our test process is currently focused on 7.x, and we're not particularly PHP experts, so unless we make this part of our testing, we'd risk breaking 5.6 without realising.

I'm also somewhat reluctant to support a PHP version that stops getting security updates next month.

Let me have a chat internally and see how we feel as a group.

Thanks again!

jawngee commented 4 years ago

Yeah, I'm honestly not expecting you to to merge this, we'll be using our fork in Media Cloud - but just understand how lagged behind modern times that most WordPress users are in the real world. And while I'm psyched to be the only WordPress plugin that integrates Mux, you guys may have other ideas down the road ;)

Thanks!

philcluff commented 3 years ago

Unfortunately we're not able to support PHP 5.X.