muxinc / mux-ruby

Official Mux API wrapper for ruby projects, supporting both Mux Data and Mux Video.
MIT License
51 stars 14 forks source link

Fix ArgumentError interpolation #26

Closed omegahm closed 3 years ago

omegahm commented 3 years ago

We were seeing errors in our logs as:

invalid value for "name", must be one of #{validator.allowable_values}.

instead of the expected

invalid value for "name", must be one of 'low.mp4', 'medium.mp4', 'high.mp4', 'audio.m4a'.

This PR fixes the interpolation of these values.

omegahm commented 3 years ago

The failed integration test complains about a missing MUX_TOKEN_ID. How do I provide that?

philcluff commented 3 years ago

Hey @omegahm, thanks for the PR.

Because this codebase is code-generated from our OpenAPI definitions, we'll need to mirror these changes into our internal templates, I'll ask the team to take a look this week.

Thanks!

eropple commented 3 years ago

We've fixed this in our templates and things should be good now. Thank you for your help - we really appreciate it!