muxinc / mux-stats-sdk-avplayer

Mux integration with `AVPlayer` for iOS Native Applications
Apache License 2.0
42 stars 21 forks source link

Installation using Carthage doesn't work. #123

Closed laxmorek closed 2 years ago

laxmorek commented 2 years ago

Hi 👋

Short description

I would like to add the MuxStatsSDK to my project using Carthage. I updated my Cartfile following documentation but installation fails when I run the carthage update command.

Env

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/6q/ytvfydhj50d9jnbk76_zcq580000gp/T/carthage-xcodebuild.SZZ0wZ.log



### Expected behavior 

I should be able to install the `MuxStatsSDK` using the `Carthage`.
laxmorek commented 2 years ago

It still occurs in 2.8.0.

laxmorek commented 2 years ago

It still occurs in 2.9.0.

nidhik commented 2 years ago

Hi @laxmorek! Thanks for reporting this issue and trying out the new release. If you use the binary specification in your Cartfile, does it work for you?

binary "https://raw.githubusercontent.com/muxinc/mux-stats-sdk-avplayer/master/MUXSDKStats.json"
binary "https://raw.githubusercontent.com/muxinc/stats-sdk-objc/master/MUXCore.json"
laxmorek commented 2 years ago

Hey @nidhik 👋 thanks for your answer.

If you use the binary specification in your Cartfile, does it work for you?

Yes it works! 🎉

Is it a preferable way to install MUX using Carthage?

nidhik commented 2 years ago

@laxmorek great news! Yes, this will be the preferred way to install the Mux SDKs with Carthage going forward. I am working on the documentation updates and will keep this issue open until we have updated our official docs. Thank you!

nidhik commented 2 years ago

Closing now that the documentation has been updated with the preferred way to install using Carthage: https://docs.mux.com/guides/data/monitor-avplayer#installing-manually-with-carthage-not-recommended