Closed luwes closed 1 month ago
vercel[bot]
commented
2 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| player-style | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 3, 2024 7:32pm |
heff
commented
2 months ago You probably saw the color of the player is meant to match the cover art. Unless there's some magic we can do to drive the automatically, let's change the color to a blue from the sky of the demo video poster, or a white like the snow.
It also pushes on the need for a color picker in the theme viewer itself, but that's not for this PR.
Is it a good thing that it automatically goes from long horizontal to stacked at smaller sizes? Now that I see it in practice, that feels hard to plan a layout around, compared to if those were different options or just different players (e.g. Sutro Stacked). Totally open to opinions on this one.
mmcc
commented
2 months ago My S1 was going to be that the sizing feels pretty doable as it is now. If you want the stacked player, just set the width to be smaller, folks are hopefully going to do that in their layout anyway. However, thinking a bit more about it I think I agree that it should probably be either an attribute you can set (layout="stacked"?). It would stink to be in a situation where you wanted a very large stacked version or a very small landscape version and not be able to do it easily.
luwes
commented
2 months ago Is it okay a stacked configuration attribute is added in a future iteration?
The stacked version is really needed on the smaller sizes because there is just so much space for the UI. Stacked can be shown on bigger player sizes too but the thumbnail will get pretty large at some point.
https://player-style-git-sutro-audio-mux.vercel.app/themes/sutro-audio