search

muxinc / strapi-plugin-mux-video-uploader

A Strapi plugin for managing uploads to Mux.
https://mux.com
23 stars 16 forks source link

Include aspect_ratio and duration as available properties. #33

Closed twobyte closed 2 years ago

twobyte commented 2 years ago

The API exposes aspect_ratio and duration asset data: https://docs.mux.com/api-reference/video#tag/assets

Can we include it in the Strapi data graph? https://github.com/muxinc/strapi-plugin-mux-video-uploader/blob/master/server/controllers/mux.ts#L48-L51

erikpena commented 2 years ago

Hello @twobyte, I don't see why not. Those two in particular seem pretty reasonable. I'll create a PR to include this.

erikpena commented 2 years ago

Tracked in PR: https://github.com/muxinc/strapi-plugin-mux-video-uploader/pull/36

twobyte commented 2 years ago

Great, thanks @erikpena. I look forward to seeing this merged!

erikpena commented 2 years ago

Hey @twobyte, this has been merged and published on npmjs as v2.2.0. Give it a spin and let me know how you get along.

Take a look at the Release notes for more information with what was included (there are other things that were deployed along with this)— https://github.com/muxinc/strapi-plugin-mux-video-uploader/releases/tag/v2.2.0

Thanks!

twobyte commented 2 years ago

Thanks @erikpena, appears to be working well.