search

muxinc / strapi-plugin-mux-video-uploader

A Strapi plugin for managing uploads to Mux.
https://mux.com
23 stars 16 forks source link

Request: Allow us to delete #69

Open johnark88 opened 1 year ago

johnark88 commented 1 year ago

Issue: No delete functionality Reproduce: Install Mux on fresh install setup token id/secret, setup webhook with ngrok and get webhook secret - in Mux dashboard. Add tokens and id's to strapi settings config in the strapi admin Upload asset via Mux Video Uploader Click delete icon then click confirm. Nothing happens, no console log and no strapi server log output.

Upon inspection it looks like the function behind the confirm button is empty..... EDIT Its possible the modal maybe closing too quickly for the function to fire, not even the before/after delete lifecycles are firing.

Any advice or help would be greatly appreciated. Thank you!

johnark88 commented 1 year ago

See PR #70 for fix

cjpillsbury commented 12 months ago

Hey @johnark88 ! Thanks for filing the issue and the PR! Let me see if someone with a bit more context has the bandwidth for a PR review.

kelihansen commented 11 months ago

I would also love to see this fixed!