Feature: editable captions/subtitles, and configurable max_resolution, mp4_support and encoding

[hdoro]

This PR makes it possible to create assets with configurable max_resolution, mp4_support and encoding_tier, as well as uploading custom subtitles/captions, or requesting auto-generation.

Closes #62 #47 #72 #68

[erikpena]

Hello @hdoro, Thank you for the PR for this. I've taken some time to review this and have some notes that I want to share with you:

• Naming conventions: for this project, we are using kebab casing for filenames but it looks like you're using capital casing. We'd want to switch to using kebab-casing if possible (e.g. SignedTokensProvider.tsx -> signed-tokens-provider.tsx).
• I am unable to build/test this plugin in a local environment due to some type issues. I think it is related to my comment regarding upgrading the versions of react/react-dom and incompatibilities with the react-router-dom dependencies.

[hdoro]

@erikpena thank you for the thorough review!

I've went through every item and created a repository configured for testing the plugin, which is documented for how to run it. Let me know if you need further help to get it running. Glad to hop on a call :)

Aside from testing and QA, is there anything else we need to get this merged and published?

[erikpena]

Hello @hdoro, I noticed that you had moved the delete action button for assets. We will need it where it was at as this was based on conditions from Strapi in order for us to get approved and "Verified".

[erikpena]

Hey @hdoro I just attempted to create a new subtitle with an asset and it's throwing a 500.

I used a file like this (named test.srt)—

1
00:00:00,498 --> 00:00:02,827
- Here's what I love most
about food and diet.

2
00:00:02,827 --> 00:00:06,383
We all eat several times a day,
and we're totally in charge

Selected "English" and left "closed captions" unchecked. When submitting the form, I get this error in the console for my —

[updateTextTracks / createAssetTextTracks] BadRequestError: 400 {"error":{"type":"invalid_parameters","messages":["input has url set to \"undefined/mux-video-uploader/mux-text-tracks/2\", which is not a valid URL."]}}

In my case, I'm hosting locally so I'm not expecting it to work fully. However, it looks like it's having issues with the url resolution on the input when sent to Mux (there is an undefined value). Can you determine what is causing this?

[erikpena]

I can see that there is still a file that is camel cased (server/utils/parseJSONBody.ts), can we change this to kebab casing (server/utils/parse-json-body.ts)?

[hdoro]

@erikpena done! That one went over my radar, thank you for spotting it :)