search

muxinc / upchunk

Uploads Chunks! Takes big files, splits them up, then uploads each one with care (and PUT requests).
MIT License
340 stars 46 forks source link

Add response objects into failure events details. #129

Closed mr-sanders closed 8 months ago

mr-sanders commented 8 months ago

This PR resolves issue #128 by incorporating response objects from the request failure handlers directly into the details of the corresponding issues.

mr-sanders commented 8 months ago

@cjpillsbury Is it applicable and sufficient to add a response.statusCode check in the 'an error is thrown if a request does not complete' and 'a chunk failing to upload fires an attemptFailure event' test cases? Or should they be separate test cases?

cjpillsbury commented 8 months ago

@cjpillsbury Is it applicable and sufficient to add a response.statusCode check in the 'an error is thrown if a request does not complete' and 'a chunk failing to upload fires an attemptFailure event' test cases? Or should they be separate test cases?

I think updating the same tests (for error and attemptFailure) is just fine.