Allow use of POST method

muxinc / upchunk

Uploads Chunks! Takes big files, splits them up, then uploads each one with care (and PUT requests).

MIT License

337 stars 46 forks source link

Allow use of POST method #23

Closed ickyicky closed 3 years ago

ickyicky commented 4 years ago

It would be nice to allow POST method, as some web services allow Content-Range header for POST method too.

mmcc commented 4 years ago

Thanks for the PR! I'm not opposed to this, but I do want to be clear that I've really only tested this library extensively with GCS's resumable uploads. Have you tried this out with another endpoint?

ickyicky commented 4 years ago

Yes, we used Your library in one of projects at my work, to transfer large files. I'm backend developer there and right now i'm forced to make a lot of PUT endpoints, which doesn't fit REST api's philosophy, so it would be nice having support for other http methods, mainly for POST. I'm not experienced with typescript, so i'm not surprised that build fails :)

mmcc commented 3 years ago

I'm really sorry, I pulled the branch locally to try and sort out the conflicts + add some tests, and somehow along the way it looks like git ended up attributing your changes to me as the committer and not closing this PR out :(

This is merged now, though, thank you so much for the contribution!