Prevent send chunks when it is finished

muxinc / upchunk

Uploads Chunks! Takes big files, splits them up, then uploads each one with care (and PUT requests).

MIT License

345 stars 46 forks source link

Prevent send chunks when it is finished #34

Closed luizmacfilho closed 3 years ago

luizmacfilho commented 3 years ago

When the online event is dispatched, it's trying to send chunks again even the success dispatch has already been called and the file is already uploaded.

dylanjha commented 3 years ago

@luizmacfilho thank you for the PR! I want to to get some small changes together for a release soon and I don't see any reason that this would not be included.

Thank you!

dylanjha commented 3 years ago

@luizmacfilho we added some more tests to master (#36) - would you mind updating your branch with upstream master please? instructions

I tried to but I'm seeing permission denied when I try to push to your repo (if you would like me to handle that, there should be a box you can check on the PR which will allow maintainers to edit your branch)

luizmacfilho commented 3 years ago

Done @dylanjha

mmcc commented 3 years ago

Thank you, @luizmacfilho!