search

muxinc / upchunk

Uploads Chunks! Takes big files, splits them up, then uploads each one with care (and PUT requests).
MIT License
337 stars 46 forks source link

Fix upload percentage calculation function #43

Closed michaellimair closed 3 years ago

michaellimair commented 3 years ago

Fix for issue https://github.com/muxinc/upchunk/issues/30

dylanjha commented 3 years ago

Hi @michaellimair thanks so much for this 🙌 I'm very keen on getting this shipped.

It would be amazing to have some test coverage on this. On the surface here the changes look good, but the logic in there is a little difficult to reason about at first glance. We made significant improvements to the test ENV in #36

Do you think you might be able to take a stab at adding tests to this PR? (and bringing it up to date with upstream changes)?

michaellimair commented 3 years ago

36

Hi Dylan! Sure, will be working on this. Should I rebase from master or just merge the master branch to my working branch?

P.S: Props to the package, we have been using it in production for my company and it really helps 👯

dylanjha commented 3 years ago

@michaellimair thanks! Whichever you prefer. Either way we will squash the final merge

michaellimair commented 3 years ago

Hi @dylanjha, I have made a test case to check the progress event and ensure it does not jump backwards.

You can have a look, thanks 😄

enormousrodent commented 3 years ago

Do we have an idea when this will be merged back in to the master branch?

dylanjha commented 3 years ago

@michaellimair wow, this looks great! 🙌🏼 🎉 Thank you for adding that extra test coverage.

@enormousrodent I'll work on getting a new release out in the next couple days!