muxinc / upchunk

Uploads Chunks! Takes big files, splits them up, then uploads each one with care (and PUT requests).
MIT License
336 stars 46 forks source link

Increase default chunkSize to 30 MB #74

Closed bgentry closed 2 years ago

bgentry commented 2 years ago

This drastically improves performance on faster connections, at the cost of potentially needing to retry a larger chunk of data when a connection is interrupted.

It's impossible to serve both fast and slow/unreliable internet connections well with a single fixed setting here, so in the future this should be made to scale dynamically to 1) maximize upload speed on fast connections, and 2) constrain the amount of time that will be wasted re-uploading a partial segment if it is interrupted.

I did not touch the version here, up to you how to deal with communicating this changed default.

bgentry commented 2 years ago

I'll let you all decide if/when/how to merge and release this since it involves versioning and new npm releases.