Closed bgila closed 2 years ago
@bgila oh hey also, as a thanks for the PR I can shoot you a shirt or something along those lines, if you're interested just ping me via email (matt at mux)
@mmcc thank you for the quick review! Just wondering, what release cadence are y'all on -- when should I expect a new package version with the change?
I sent an email with my address too :D
I went ahead and cut a patch release for this, should be live on NPM already. Thanks again!
resolves #62 which was causing an infinite recursion when an event is dispatched.
updated
event-target-shim
andtypescript
versions, made a couple typescript fixes inupchunk.ts
to ensure tests still pass.not very knowledgeable with typescript, so if there's better ways to resolve the typescript issues that appear when upgrading typescript versions, would appreciate help on those
if we can merge this in, it'll allow Sprig to use Mux's upchunk directly instead of our fork, which we've been using for some months now.