search

muxinc / videojs-mux-kit

MIT License
33 stars 11 forks source link

inject our own player details in data reporting & first look at a github workflow #6

Closed james-mux closed 3 years ago

james-mux commented 3 years ago

Couple of things in this PR; 1) Handle setting our own player_software_name and player_software_version - this was a little messy as depending if you init Data via JS, or on the element, it comes through in slightly different places - but I think this covers both options

2) A first attempt at a workflow to publish over on NPM through actions. This relies on us getting some tests in first, and I also don't know if we need to check over package.json to make sure we've got stuff named as we want?

Either way, thoughts appreciated!

james-mux commented 3 years ago

Hmm, so all these tests are passing locally

james-mux commented 3 years ago

... and they worked after another attempt

james-mux commented 3 years ago

@dylanjha would you give this one last 👀 please?

dylanjha commented 3 years ago

These changes LGTM, but the flakey tests should be addressed before releasing. Opened #8 to debug it