muxinc / videojs-mux-kit

MIT License
33 stars 11 forks source link

fix: fix node environment import #65

Closed gkatsev closed 2 years ago

gkatsev commented 2 years ago

Fixes #59

cjpillsbury commented 2 years ago

The issue was obliquely build-related, but more specifically an issue with properties of an hls.js instance being referenced in a node runtime, including constants. By moving any of these references to within the corresponding method scopes, this obviates the problem occurring as a result of simply importing or requiring the @mux/videojs-kit in these environments.

cjpillsbury commented 2 years ago

Confirmed reproduction of issue in two ways:

Confirmed solution by: