search

muxinc / videojs-mux-kit

MIT License
33 stars 11 forks source link

fix: only trigger fatal errors on player #72

Closed gkatsev closed 2 years ago

gkatsev commented 2 years ago

hls.js triggers a bunch of errors on various occasions. A lot of the errors are automatically recovered by hls.js, these are non-fatal errors. Video.js's error events are basically reserved for fatal errors, therefore, we should only bubble up fatal errors.

gkatsev commented 2 years ago

Tested with:

$0.player.on('error', (e) => console.log('error'))
$0.player.tech_.sourceHandler_.hls.trigger('hlsError', { type: 'mediaError', fatal: true})
// < "error"
$0.player.tech_.sourceHandler_.hls.trigger('hlsError', { type: 'mediaError', fatal: false})