muxinc / videojs-mux-kit

MIT License
33 stars 11 forks source link

debugging intermittent test failures #8

Closed dylanjha closed 3 years ago

dylanjha commented 3 years ago

seems like tests were failing intermittently

opening this with empty commits in order to debug

dylanjha commented 3 years ago

Feels like a race condition

PASS browser: webkit test/e2e/data.test.js
FAIL browser: chromium test/e2e/basic.test.js
  ● Basic demo page › should load

    Cannot find object to emit "close": Worker@23c09896c7607bafa2f6f59f136a54be

      at Connection.dispatch (../node_modules/playwright/lib/client/connection.js:115:19)
      at Immediate.setImmediate (../node_modules/playwright/lib/inprocess.js:37:85)

PASS browser: firefox test/e2e/basic.test.js
PASS browser: webkit test/e2e/basic.test.js

@james-mux @erikpena looks like there's a flakey test that fails intermittently

james-mux commented 3 years ago

@erikpena - is this what you saw the other day on main?

erikpena commented 3 years ago

I think we can delete this pull because the issues above was resolved with the hot mess of https://github.com/muxinc/videojs-mux-kit/pull/9 💯