muzairkhattak / multimodal-prompt-learning

[CVPR 2023] Official repository of paper titled "MaPLe: Multi-modal Prompt Learning".
https://muzairkhattak.github.io/multimodal-prompt-learning/
MIT License
619 stars 43 forks source link

Using subsample as new gives really bad acc #11

Closed gordonhu608 closed 1 year ago

gordonhu608 commented 1 year ago

I noticed that in the reproduce_maple.sh. You used different output directories for base and new but used the same directory for the model path. However, it seems like dassl is looking for the output path for the trained model, if it's not found, then it starts training even when I'm using the same model path. So I used the same output dir for new as the base out dir and only change the subclass to "new". However, I can't reproduce the results for "new", receiving very bad acc. I'm sure I didn't change everything else. Why this would happen? Thanks ahead.

muzairkhattak commented 1 year ago

Hi @gordonhu608 ,

Thank you for reaching out to us.

I believe you should keep the output directories separate for both the base and new classes. As both base and new classes utilize the same model, that is why the directory for the model path is same.

You should not change any setting in reproduce_maple.sh other than the dataset path value. I also re-verified the steps to reproduce the results and it is working for me.

Just to re-iterate, you can perform the following steps to reproduce the results.

Running the above steps will produce results for both base and novel classes. Note that you should re-produce the results for all three seeds and then take average to obtain the final results which are reported in the main paper.

I hope this will be helpful.

Kindly let us know incase there is any further confusion or query.

Thank you and kind regards.

gordonhu608 commented 1 year ago

Thank you so much

muzairkhattak commented 1 year ago

No problem!