Code enhancements for flutter

muzammildafedar commented 2 months ago

We are looking to enhance the existing codebase of our flutter. This issue aims to discuss and implement various improvements that can lead to better performance, maintainability, and overall code quality.

Enhancements Suggestions:

Code Refactoring: Identify any areas in the codebase that could benefit from refactoring to improve readability and reduce complexity.

Performance Optimization: Look for opportunities to optimize the performance of the app, including minimizing widget rebuilds, improving loading times, etc.

Add Comments and Documentation: Ensure that all critical sections of the code are well-commented. This will help new contributors understand the logic and purpose of various components.

Update Dependencies: Review and update any outdated dependencies in the pubspec.yaml file to their latest stable versions.

Improve Error Handling: Enhance error handling throughout the application to ensure a smoother user experience and better debugging capabilities.

Implement Best Practices: Follow Flutter and Dart best practices (such as proper state management, separation of concerns, etc.) in the codebase.

Unit Testing: Increase the coverage of unit tests across various modules to ensure code reliability and facilitate future changes.

Additional Notes:

Please feel free to add more suggestions or areas of improvement based on your experience with the codebase.

Let's discuss the priorities and assign tasks accordingly.

Amitkumarkoli commented 1 month ago

Hey! can I work on this? u can assign it to me!

also can I add new issues on this projects? any restrictions for new issues?

muzammildafedar commented 1 month ago

@Amitkumarkoli Don't forget to fork the repository before getting started. Feel free to take on any existing issues or create a new issue following proper open-source guidelines. You can also propose a new feature by first creating an issue with a clear description and expected behavior. Looking forward to your contributions!

muzammildafedar commented 1 month ago

@Amitkumarkoli are you still working on this issue?

LaPyaeOo commented 1 month ago

Suppose he is doing this issue. I will take it and may start to enhance it. Later he can follow that. How about @muzammildafedar ?

muzammildafedar commented 1 month ago

Suppose he is doing this issue. I will take it and may start to enhance it. Later he can follow that. How about @muzammildafedar ?

Sounds good to me.

Amitkumarkoli commented 1 month ago

I am still working on it Sorry for the late response, I was busy with some other task, hope u doing mine @muzammildafedar

LaPyaeOo commented 1 month ago

The Flutter version of the project is 3.19.6 now. Should we upgrade?

muzammildafedar commented 1 month ago

The Flutter version of the project is 3.19.6 now. Should we upgrade?

Thank you for bringing this up. Before proceeding with the upgrade, I'd like to check which dependencies might be affected by moving to the new version. Please go ahead and upgrade to the latest Flutter version, and let me know if any packages are impacted during the process. Once we identify the affected dependencies, we can address any issues accordingly.

Amitkumarkoli commented 1 month ago

**hey I rebooted my system due to some issue and now when I reinstalled everything then my project is not running, i have mentioned below error.

can u pls help to run this project??**

Warning: In index.html:63: Local variable for "serviceWorkerVersion" is deprecated. Use "{{flutter_service_worker_version}}" template token instead. Warning: In index.html:201: "FlutterLoader.loadEntrypoint" is deprecated. Use "FlutterLoader.load" instead. /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/src/widgets/toolbar_widget.dart: 1123:68: Error: The getter 'headline6' isn't defined for the class 'TextTheme'.

'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'headline6'. style: Theme.of(context).textTheme.headline6), ^^^^^^^^^ /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/src/widgets/toolbar_widget.dart: 1875:56: Error: The getter 'bodyText1' isn't defined for the class 'TextTheme'.
'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'bodyText1'. .bodyText1 ^^^^^^^^^ /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/src/widgets/toolbar_widget.dart: 1982:56: Error: The getter 'bodyText1' isn't defined for the class 'TextTheme'.
'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'bodyText1'. .bodyText1 ^^^^^^^^^ /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/src/widgets/toolbar_widget.dart: 2134:56: Error: The getter 'bodyText1' isn't defined for the class 'TextTheme'.
'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'bodyText1'. .bodyText1 ^^^^^^^^^ /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/src/widgets/toolbar_widget.dart: 2286:56: Error: The getter 'bodyText1' isn't defined for the class 'TextTheme'.
'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'bodyText1'. .bodyText1 ^^^^^^^^^ /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/src/widgets/toolbar_widget.dart:2438:56: Error: The getter 'bodyText1' isn't defined for the class 'TextTheme'.
'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'bodyText1'. .bodyText1 ^^^^^^^^^ /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/utils/utils.dart:952:51: Error: The getter 'subtitle1' isn't defined for the class 'TextTheme'.
'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'subtitle1'. widget.style ?? Theme.of(context).textTheme.subtitle1; ^^^^^^^^^ /C:/Users/ASUS/AppData/Local/Pub/Cache/hosted/pub.dev/html_editor_enhanced-2.5.1/lib/utils/utils.dart:1012:37: Error:The getter 'subtitle1' isn't defined for the class 'TextTheme'.
'TextTheme' is from 'package:flutter/src/material/text_theme.dart' ('/C:/flutter/packages/flutter/lib/src/material/text_theme.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'subtitle1'. Theme.of(context).textTheme.subtitle1!.fontSize!; ^^^^^^^^^ Waiting for connection from debug service on Chrome... 96.8s Failed to compile application.

SS-

Screenshot 2024-10-08 070953 Screenshot 2024-10-08 071016

LaPyaeOo commented 1 month ago

I mentioned it before and added it to the readme file. This error was caused by the Flutter version. Change your local Flutter version to 3.19.6 and you can run after that.

Amitkumarkoli commented 1 month ago

### When I am try to change version using fvm it showing me this (ss below) any another way to change version or handle this error??

Screenshot 2024-10-08 204501

muzammildafedar commented 1 month ago

### When I am try to change version using fvm it showing me this (ss below) any another way to change version or handle this error??

Have you tried to install in the root mode?

Amitkumarkoli commented 1 month ago

yes already tried but nothing happened!

LaPyaeOo commented 1 month ago

Try with puro. It is the alternative way and I suppose easier than FVM.

muzammildafedar commented 1 month ago

@Amitkumarkoli how's your progress on this?

Amitkumarkoli commented 1 month ago

I am working on doc rn and i added comments in code , and checking imp code (for enhancing the code ) , and dependencies is already updated . For now can i make the pr on new readme and doc?

LaPyaeOo commented 1 month ago

Does someone work on this?

Amitkumarkoli commented 1 month ago

I am working on this , and I updated the readme file and added the contrubuting.md separate file and also added comments for new contributors , dependencies are updated already , and currently working on logic and try to update it . so, @muzammildafedar can I make the pr on this for now, and u can merge it but dont close the issue , so I can work further on this ?? once I satisfy with my changes I will create new pr on this, pls reply !!

muzammildafedar commented 1 month ago

Sure, @Amitkumarkoli. I suggest that you and @LaPyaeOo divide the code into separate folders for better code enhancement. This way, @LaPyaeOo can work on parts of the code that haven't been improved yet. @Amitkumarkoli, you can mention the sections of the code where no enhancements have been made so that @LaPyaeOo can start working on those. Alternatively, you both can discuss and split the entire codebase between yourselves. Let me know if this sounds like a good idea.

Amitkumarkoli commented 1 month ago

sounds good to me ! @LaPyaeOo so , I already updated the readme file and added the contrubuting.md separate file and also added comments for new contributors , dependencies are updated . let me know ur work on this , I am suggesting, u can work on all the logic and testing areas if it fit for u .

muzammildafedar / udayah