\thmtlo@newentry unnecessarily called twice for every theorem

[mbertucci47]

In thm-listof.sty, the command \thmtlo@newentry which defines l@<theorem> is called multiple times for every theorem. Once in \thmt@mklistcmd which is added to every theorem definition:

\newcommand\thmt@mklistcmd{%
  \thmtlo@newentry
  ...
}

then

\g@addto@macro\thmt@newtheorem@predefinition{%
  \thmt@mklistcmd
  \thmt@recordenvname
}

And again for every call of \listoftheorems:

\newcommand\listoftheorems[1][]{%
...
  \@for\thmt@envname:=\thmt@allenvs\do{%
    % CHECK: is \cs{l@\thmt@envname} repeatedly defined?
    \thmtlo@newentry
  }%
...
}

And indeed, removing either the first \thmtlo@newentry above or the \@for block seems to have no effect. I guess removing the \@for block is more efficient since it leads to fewer total definitions.

Note the % CHECK: comment is in the file, not added by me.