search

muzny / tiletothetop

Repo for web app based vocabulary game.
0 stars 0 forks source link

Add a "Share" button for statically linked word lists #23

Closed muzny closed 11 years ago

muzny commented 11 years ago

Maybe we should add a share button that pops up a text box with the url to share. (Adam got the statically linked word lists done this afternoon).

ghost commented 11 years ago

34

not really sure how to reference other bugs, but this is blocking my progress on this. exterior to facebook this is functional, though

ghost commented 11 years ago

Problem: facebook doesn't allow you to post links to local urls, but we have to use localhost to sign in to facebook to begin with.

Possible workarounds: put our dev envs behind a routed url, so facebook likes it. Still won't work for other people. but we can test. deploy! all these problems should go away after deployment, but we should deploy early to bug test.

thoughts?

muzny commented 11 years ago

I think that deployment doesn't take too much effort, so why don't we plan on doing an initial deploy soon (tonight/tomorrow) so that we can test all these things that should work on the live site? Then we can do a final deploy later.

ghost commented 11 years ago

sounds fine to me, there's still two things that should be done that I can work on till then

  1. make call to facebooks api on the backend, to hide our auth token
  2. make form to customize post contents

I have absolutely zero experience with django forms, so the second might take some time if I'm on my own for it.

ghost commented 11 years ago

number 2 done. We should really consider finding a way to make these facebook posts work.

muzny commented 11 years ago

When I was playing, finished a game, and pushed the "share" button when I was not signed in, this is what I got:

http://tiletothetop.herokuapp.com/?id=undefined

It works properly when I am signed in though.

Should we disable sharing when the user is not signed in?

ghost commented 11 years ago

thats the plan. I'm also disabling it when the user quits the game.

On Tue, Dec 4, 2012 at 6:03 PM, muzny notifications@github.com wrote:

When I was playing, finished a game, and pushed the "share" button when I was not signed in, this is what I got:

http://tiletothetop.herokuapp.com/?id=undefined

It works properly when I am signed in though.

Should we disable sharing when the user is not signed in?

— Reply to this email directly or view it on GitHubhttps://github.com/muzny/tiletothetop/issues/23#issuecomment-11025191.

ghost commented 11 years ago

I think I'm done on the development side here. Just need to test.