muzny / tiletothetop

Repo for web app based vocabulary game.
0 stars 0 forks source link

Deployment issues #54

Closed muzny closed 11 years ago

muzny commented 11 years ago

I was trying to test the {score} replacement feature because localhost can't post to facebook (as far as I can tell), so I deployed the app, but it broke. Not only was my feature not there (message having actual score populated), but the toggle feature that Laura just added wouldn't toggle - you couldn't change the difficulty.

Maybe I was deploying wrong... can someone check this out?

Side note - why do we need a toggle for difficulty? Does it need to lock for any certain reason?

lauredon commented 11 years ago

On the toggle thing: might need to make sure you do a hard refresh? I had to update the javascript. Though I'm thinking disabling is unnecessary since it can behave weird sometimes because the browser caches stuff in input boxes.

I thought it would make sense to be able to not choose a difficulty (like the "any" option we had earlier) since we are also able to not choose a tag. I don't like adding more stuff to the start screen, but it felt weird to not have the option. Votes for/against?

muzny commented 11 years ago

Can we change the text to "any difficult" then? and maybe put the text "or" between? so that it is "[difficulty selection] or [any difficulty]"

I think that would be clearer (at least to me) :D

muzny commented 11 years ago

The new facebook posting thing doesn't appear to be working. I might have broken this, though maybe not.... Justin, can you look into it?

ghost commented 11 years ago

I'm on my way home now, I'll check when I get home too.

Sent from my iPhone

On Dec 8, 2012, at 13:21, muzny notifications@github.com wrote:

The new facebook posting thing doesn't appear to be working. I might have broken this, though maybe not.... Justin, can you look into it?

— Reply to this email directly or view it on GitHub.

jmcmanus commented 11 years ago

It's working for me. localhost and heroku

On Sat, Dec 8, 2012 at 2:10 PM, dkeka notifications@github.com wrote:

I'm on my way home now, I'll check when I get home too.

Sent from my iPhone

On Dec 8, 2012, at 13:21, muzny notifications@github.com wrote:

The new facebook posting thing doesn't appear to be working. I might have broken this, though maybe not.... Justin, can you look into it?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/muzny/tiletothetop/issues/54#issuecomment-11164387.

jmcmanus commented 11 years ago

Also, if you're planning on deploying, and you've changed any javascript, you need to run the minifier with fab compress and commit the minified version, because only the minified js is included in the deployed app.

On Sat, Dec 8, 2012 at 2:43 PM, Justin McManus jmcmanu@gmail.com wrote:

It's working for me. localhost and heroku

On Sat, Dec 8, 2012 at 2:10 PM, dkeka notifications@github.com wrote:

I'm on my way home now, I'll check when I get home too.

Sent from my iPhone

On Dec 8, 2012, at 13:21, muzny notifications@github.com wrote:

The new facebook posting thing doesn't appear to be working. I might have broken this, though maybe not.... Justin, can you look into it?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/muzny/tiletothetop/issues/54#issuecomment-11164387.

ghost commented 11 years ago

I repro'd the bug. Firefox only

went ahead and fixed it also.