Fixing the punctuation marks direction in the RTL languages

[Essam23]

Hi, in Netflix the punctuation marks in the RTL languages (Arabic) are not displayed in the correct direction, it looks like this

when it should look like this

Fixing this problem could be done by adding

"‏":"‫"

there is a hidden Unicode control character between "" (202B RIGHT-TO-LEFT EMBEDDING)

https://unicode.scarfboy.com/?s=%22%26rlm%3B%22%3A%22%E2%80%AB%22

the same hidden Unicode control character that is used in Subtitle Edit to fix the punctuation marks direction in the RTL languages.

I tested it by myself and it worked just fine.

[muzuiget]

I can't copy and parse your code to my code editor.

It better to use \uXXXX to escape the Unicode character, so can this work?

'‎': '\u202b',

Here is I test in console:

[muzuiget]

Please also read this issue https://github.com/muzuiget/dualsub-support/issues/129

[Essam23]

Thank you, this worked.

'‏': '\u202b',

for more information about this problem see here.

https://github.com/rsimmons/subadub/commit/c585fda90c8c5cb742f4fcaac693bd066f25b55a

[muzuiget]

After reading the wiki https://en.wikipedia.org/wiki/Right-to-left_mark, I think we should use \u200f. Current code is just remove the ‏.

So the change should be:

-    '‎': '',
+    '‎': '\u200e',
+    '‏': '\u200f',

[Essam23]

This is a subtitle file you could use for testing.

Spider-Man.2.2004.zip

[Essam23]

This is how inputstream.adaptive fixed this problem

https://github.com/xbmc/inputstream.adaptive/commit/0c3f167259454d628ca883358ef359618d770909

[muzuiget]

It is difficult for me to recognize Arabic characters.

[Essam23]

The full stop must be to the left, that is all what you need.

[muzuiget]

The XBMC code show that we should use \u200e and \u200f. as the wiki says:

In Unicode, the RLM character is encoded at U+200F RIGHT-TO-LEFT MARK (HTML ‏ · ‏). In UTF-8 it is E2 80 8F. Usage is prescribed in the Unicode Bidi (bidirectional) Algorithm.[1]

[Essam23]

It did not work, I tried it now.

l={"&amp;":"&","&lt;":"<","&gt;":">","&quot;":'"',"&#39;":"'","&lrm;":"","&rlm;":"\u200f"}

[muzuiget]

As the issue https://github.com/muzuiget/dualsub-support/issues/129 says, you should add the the CSS direction: rtl; to the HTML node.

[Essam23]

I know this problem very well, and the fix that is done in Subadub and inputstream.adaptive was my idea, I deal with the subtitles a lot, please take my word in this problem.

[Essam23]

This was the fix that is done by the developer of inputstream.adaptive and it did not work

https://github.com/xbmc/inputstream.adaptive/commit/d713b9557f5d0088a17ff0bca7092f7291445430

this is the one that worked

https://github.com/xbmc/inputstream.adaptive/commit/126101883b4541ebca93925d803d8de03b69adba

Until Netflix made some changes in the subtitles and we had to find a new fix.

[muzuiget]

Note: https://github.com/muzuiget/dualsub-support/issues/337#issuecomment-915121227 I have a typo, it should be '‏': '\u202b',.

[muzuiget]

Alright, replace ‏ to \u202b.

How about '‎? replace it with empty string or \u202a?

[Essam23]

For me I can not see the difference.

[muzuiget]

For consistency, I choose \u202a.

-    '‎': '',
+    '‎': '\u202a',
+    '‏': '\u202b',

[muzuiget]

v1.68.0 released.

[Essam23]

Thank you so much, It works perfectly.