mvabdi / vsco-scraper

Easily allows for scraping a VSCO
MIT License
132 stars 25 forks source link

Problems with Linux filesystem on v0.47 #6

Closed bamtan closed 5 years ago

bamtan commented 6 years ago

Hi, when issuing the following command: vsco-scraper vsco_user -i

It creates a new folder called my_username\vsco_user inside my /home/ directory (/home/my_username\vsco_user). This makes the program require elevation to run, and outputs permission errors.

Traceback (most recent call last):
  File "/usr/local/bin/vsco-scraper", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 211, in main
    scraper = Scraper(args.username)
  File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 24, in __init__
    os.makedirs(path)
  File "/usr/lib/python3.5/os.py", line 241, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '/home/my_user\\vsco_user'
mvabdi commented 6 years ago

Was it working previously?

On Sun, Aug 19, 2018, 10:00 AM bamtan notifications@github.com wrote:

Hi, when issuing the following command: vsco-scraper vsco_user -i

It creates a new folder called my_username\vsco_user inside my /home/ directory (/home/my_username\vsco_user). This makes the program require elevation to run, and outputs permission errors.

Traceback (most recent call last): File "/usr/local/bin/vsco-scraper", line 11, in sys.exit(main()) File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 211, in main scraper = Scraper(args.username) File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 24, in init os.makedirs(path) File "/usr/lib/python3.5/os.py", line 241, in makedirs mkdir(name, mode) PermissionError: [Errno 13] Permission denied: '/home/my_user\vsco_user'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mvabdi/vsco-scraper/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AfBeB_1esFmYh7_ARgfMbJ8XCI99IUAlks5uSW91gaJpZM4WC-gL .

bamtan commented 6 years ago

I haven't used any other version aside from the fix made in #2, v0.37

harangutang commented 6 years ago

I forked it and changed a few lines and on my debian machine it solved the issue. You should be able to see it on my page.

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On August 19, 2018 6:32 PM, Mustafa Abdi notifications@github.com wrote:

Was it working previously?

On Sun, Aug 19, 2018, 10:00 AM bamtan notifications@github.com wrote:

Hi, when issuing the following command: vsco-scraper vsco_user -i

It creates a new folder called my_username\vsco_user inside my /home/ directory (/home/my_username\vsco_user). This makes the program require elevation to run, and outputs permission errors.

Traceback (most recent call last): File "/usr/local/bin/vsco-scraper", line 11, in sys.exit(main()) File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 211, in main scraper = Scraper(args.username) File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 24, in init os.makedirs(path) File "/usr/lib/python3.5/os.py", line 241, in makedirs mkdir(name, mode) PermissionError: [Errno 13] Permission denied: '/home/my_user\vsco_user'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mvabdi/vsco-scraper/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AfBeB_1esFmYh7_ARgfMbJ8XCI99IUAlks5uSW91gaJpZM4WC-gL .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

bamtan commented 6 years ago

Can confirm that harangutang's fix from his fork is working on my Linux machine.

mvabdi commented 6 years ago

If it works on Windows as well, make a pull request. Thanks for the fix!

On Mon, Aug 20, 2018, 2:01 AM harangutang notifications@github.com wrote:

I forked it and changed a few lines and on my debian machine it solved the issue. You should be able to see it on my page.

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On August 19, 2018 6:32 PM, Mustafa Abdi notifications@github.com wrote:

Was it working previously?

On Sun, Aug 19, 2018, 10:00 AM bamtan notifications@github.com wrote:

Hi, when issuing the following command: vsco-scraper vsco_user -i

It creates a new folder called my_username\vsco_user inside my /home/ directory (/home/my_username\vsco_user). This makes the program require elevation to run, and outputs permission errors.

Traceback (most recent call last): File "/usr/local/bin/vsco-scraper", line 11, in sys.exit(main()) File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 211, in main scraper = Scraper(args.username) File "/usr/local/lib/python3.5/dist-packages/vscoscrape/vscoscrape.py", line 24, in init os.makedirs(path) File "/usr/lib/python3.5/os.py", line 241, in makedirs mkdir(name, mode) PermissionError: [Errno 13] Permission denied: '/home/my_user\vsco_user'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mvabdi/vsco-scraper/issues/6, or mute the thread < https://github.com/notifications/unsubscribe-auth/AfBeB_1esFmYh7_ARgfMbJ8XCI99IUAlks5uSW91gaJpZM4WC-gL

.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mvabdi/vsco-scraper/issues/6#issuecomment-414205596, or mute the thread https://github.com/notifications/unsubscribe-auth/AfBeB2U9jQ4cAjmIrl-avUS31OoILWwRks5uSlCpgaJpZM4WC-gL .

bamtan commented 6 years ago

Tested on Windows 10 1803, working correctly. @harangutang are you able to make a pull request?