search

mvac7 / SDCC_PT3player_Lib

SDCC PT3 Player (Vortex Tracker) Library for MSX
21 stars 2 forks source link

IX register protection ? #1

Closed ericb59 closed 3 years ago

ericb59 commented 4 years ago

HEllo,

Thank you for this nice PT3 Replayer for SDCC. I just have a question ... I do not see IX Register protection (Push / Pop) inside the PT3Decode routine. It may cause some troubles ? No ?

mvac7 commented 4 years ago

Hi Eric! I think I learned it by imitation. Looking at the assembly output of the SDCC compiler, I saw that in C functions that do not contain parameters, it does not add the save/recall instructions from IX to the Stack. In the tests it did not give me problems, but I am not sure if they are necessary. I am not an expert. ;)

mvac7 commented 3 years ago

@ericb59 You are right. Corrected! Thanks! :)