.critical() should not be needed when fail-fast strategy is used

mvallim / java-fluent-validator

Java Fluent Validator is inspired by Fluent Interface and .Net FluentValidation which defined an inner-DSL within Java language for programmers to use. A fluent interface implies that its primary goal is to make it easy to SPEAK and UNDERSTAND.

https://mvallim.github.io/java-fluent-validator/

Apache License 2.0

160 stars 17 forks source link

.critical() should not be needed when fail-fast strategy is used #48

Open bakatz opened 5 years ago

bakatz commented 5 years ago

It seems strange to require .critical() on each rule when failfast is already enabled - just wanted to file a suggestion to consider changing this design to not require the extra .critical() call

Side note: nice work on this library. This is the best alternative to FluentValidation (.NET library) that I've found for java. Thanks!

mvallim commented 5 years ago

Hi @bakatz,

It makes sense to say that making the critical statement less verbose when failFastRule is enabled.

I will work on this issue and the next release will be available.

Thanks for the feeback, I really appreciate it!

Regards,