mvan231 / Scriptable

MIT License
115 stars 39 forks source link

Problem and features request #3

Closed Yumega closed 3 years ago

Yumega commented 3 years ago

Firstly,Thanks for your contribution of the codes.

Problem I met: it works very well if I don't set photos as background,but when I set the background with a photo sliced by the no background js, everything was good on setting and I could see the widget display result on the final setting step,but on the screen it tells Alerts are not supported in a widget.

6CB951B7-FD62-498E-9552-E83C3407C574

Feature request: The widget looks better if the words color can change into white above the photo background. Like the below ones,it seems that there is a transparent layer between the words and photo, they look nice.

5FF71E9B-FE29-4E83-BDBF-6B1AFFA7206C.

Thanks.

mvan231 commented 3 years ago

For the first bit, the alert is the popup you see during setup. I'm working through some things to make the code more efficient right now actually. But when the widget refreshes that should go away.

As for the font color, what color are you thinking it should be? The images you shared are interesting but I'm not sure what you're meaning to have me change

Also, I assume this is for the calendar widget. Is that correct?

If you have any modifications you've made, you can kindly submit a pull request and I'll review it

Yumega commented 3 years ago

I hope the color of all the fonts is white as the fonts on the photo I shared

mvan231 commented 3 years ago

You want all of the font colors to be white?

I have made the ability to use the calendar color as the event name color or not but the font color is still dependent on dark/light mode. Maybe you can show an actual example of the widget and how you'd like to see it. Or you could try modifying it and send me a pull request with the info.

Looking forward to your feedback

mvan231 commented 3 years ago

I think you can check v1.5 that I just released and it might be exactly what you were looking for

sleepyhellow commented 3 years ago

Hi, would it be possible to make this as a large widget?

mvan231 commented 3 years ago

Hi, would it be possible to make this as a large widget?

Are you still talking about the Calendar Indicator widget?

sleepyhellow commented 3 years ago

No, I‘m talking about the events you can see. Sorry that was not clear to understand. Would be nice to see the events of the next view weeks (i. e. 14 days). 84B33D3C-97EE-43B2-8E34-CDBBFE4DE2D4

mvan231 commented 3 years ago

No, I‘m talking about the events you can see. Sorry that was not clear to understand. Would be nice to see the events of the next view weeks (i. e. 14 days). 84B33D3C-97EE-43B2-8E34-CDBBFE4DE2D4

The answer to my question then is, yes, not, no.

You're looking to have additional functionality for a large size widget added. That view looks interesting. I'll see what I can do

sleepyhellow commented 3 years ago

Thanks.

mvan231 commented 3 years ago

I hope the color of all the fonts is white as the fonts on the photo I shared

Did you find the latest version to be what you were looking for?

mvan231 commented 3 years ago

Based on the new improvements that have been added in 1.5 and 1.6 I'm going to close this

mvan231 commented 3 years ago

No, I‘m talking about the events you can see. Sorry that was not clear to understand. Would be nice to see the events of the next view weeks (i. e. 14 days). 84B33D3C-97EE-43B2-8E34-CDBBFE4DE2D4

@sleepyhellow i couldn't find a good way to get in touch with you, but would you want to beta test the new large widget size feature?