mvantellingen / python-zeep

A Python SOAP client
http://docs.python-zeep.org
Other
1.87k stars 579 forks source link

Indent code block for extra HTTP headers #1334

Open AndTheDaysGoBy opened 1 year ago

AndTheDaysGoBy commented 1 year ago

One the following line, https://github.com/mvantellingen/python-zeep/blob/2f35b7d29355ba646f5e3c6e9925033d5d6df8bb/src/zeep/wsdl/bindings/soap.py#L103 shouldn't this be indented into the if client block? Otherwise, the situation could arise where client is None, resulting in a AttributeError on performing client.settings.extra_http_headers

I mention because I ran into this issue when I constructed by client, used the service proxy tutorial to change the location the WSDL was pointing to, and proceeding to attempt to generate an example message via service._binding.create_message