search

mvanthoor / rustic

Rustic is a chess engine. It is written from scratch in the Rust programming language.
https://rustic-chess.org/
GNU General Public License v3.0
132 stars 7 forks source link

Killer move value error? #71

Open Lucas-dominguez opened 1 year ago

Lucas-dominguez commented 1 year ago

Hello, Here https://github.com/mvanthoor/rustic/blob/17b15a34b68000dffb681277c3ef6fc98f935a0b/src/search/sorting.rs#L67 it should be value = MVV_LVA_OFFSET - ((n as u32 + 1) * KILLER_VALUE); because n is the index of the while loop.

Because as it is the killer value will depend on the order of global moves and not on the order of killersmoves as you said in the blog.

But maybe it's not a problem.

Have a nice day.

mvanthoor commented 2 months ago

Thanks for reporting this. I'll leave the issue open to remind myself to take a look at this and test if there is a difference.