search

mvasil / fashion-compatibility

Learning Type-Aware Embeddings for Fashion Compatibility
BSD 3-Clause "New" or "Revised" License
152 stars 42 forks source link

when create the mask, can mask_len = 0? #33

Open Cloud-Island opened 2 years ago

Cloud-Island commented 2 years ago

Under the default parameter setting, args.dim_embed = 64, n_conditions = 66. args.dim_embed / n_conditions = 0.9696,
mask_len = int(args.dim_embed / n_conditions) = int (0.9696) = 0 so mask_array is a matrix of zero. Can I change the int() to round()?

            mask_array = np.zeros([n_conditions, args.dim_embed])
            mask_len = int(args.dim_embed / n_conditions)        # mask_len = round(args.dim_embed / n_conditions) ?
            for i in range(n_conditions):
                mask_array[i, i*mask_len:(i+1)*mask_len] = 1         # mask_array[i, min(args.dim_embed-1, i*mask_len):min(args.dim_embed-1,(i+1)*mask_len)] = 1
marzooq-unbxd commented 1 year ago

did you figure this out?