search

mvdan / bitw

Minimalist BitWarden client
BSD 3-Clause "New" or "Revised" License
169 stars 15 forks source link

Fix crash when organization ciphers are used #43

Closed quexten closed 1 year ago

quexten commented 1 year ago

The cryptographic routines for organization are not yet implemented. This leads to a crash when organization owned ciphers are decrypted. Until organizations are properly implemented, this PR fixes the crash by skipping organization entries.

This makes dump correctly decrypt all non-organization ciphers in the vault, the organization entries are skipped.

Related issue is #19

quexten commented 1 year ago

FYI I'm now working on just implementing org support, so no need to merge this ;)

mvdan commented 1 year ago

Ah, I was wondering where the fourth PR went.

FYI there are tests which cover the main features and some edge cases, but they talk to the real bitwarden API. Though CI stopped working reliably as they started heavily rate limiting the API. It would be good to have tests with your fixes and new features, but it's also not very practical right now.

quexten commented 1 year ago

Thanks for the quick reviews and the info! I will look into writing test cases after finishing up this PR :)