Incorrect formatting of var block

[moorereason]

Given:

var (
    // foo
    b = 2
)

Becomes:

var (// foo
var b = 2

Tested with gofumpt v0.1.1 and 0952458e3d6b38a311cd744b440dbcd63ffb0c42

[mvdan]

Thanks, this seems like a bug. The easiest solution is likely to not change the declaration to be single-line if there's a comment in between the tokens.

[mvdan]

Hm, I actually can't reproduce:

$ cat /tmp/f.go
package p

var (
        // foo
        b = 2
)

var (
        //_ io.ReadCloser = &Decoder{}

        _ io.WriteCloser = &Encoder{}
)
$ gofumpt -version
v0.1.1-0.20210429074948-20d3d7f4c8ad
$ gofumpt /tmp/f.go
package p

// foo
var b = 2

//_ io.ReadCloser = &Decoder{}

var _ io.WriteCloser = &Encoder{}

Sometimes this is only reproducible as part of a much bigger file. If you could provide such a file, that would help.

cc @mpldr

[mvdan]

Also worth noting that I'm on go version go1.16.4 linux/amd64.

[mpldr]

my file is literally:

package yenc

import "io"

var (
    _ io.ReadCloser = &Decoder{}

    _ io.WriteCloser = &Encoder{}
)

and commenting out the first constraint.

[mvdan]

@mpldr I still can't reproduce, the output isn't broken for me, it's just:

//_ io.ReadCloser = &Decoder{}

var _ io.WriteCloser = &Encoder{}

Can you share the exact versions of Go and gofumpt where this breaks, and how you ran gofumpt?

[mpldr]

❯ go version
go version go1.16.4 linux/amd64
❯ gofumpt --version
v0.1.1

[mvdan]

And how are you running gofumpt? gofumpt your_file.go works fine for me with those same exact versions.

[mpldr]

inside vim-go, let me check

[mpldr]

It seems (if i read the code correctly) that it writes the file the file to a temppath, and then calls gopls with gofumpt set as the formatter.

[mvdan]

Right - that adds its own complexity. You'd have to find out what version of gopls, and thus gofumpt, that ends up running. Because it's not the same version you see on your command line.

[mvdan]

Also, if this is a bug that you can reproduce with vim-go but not with gofumpt directly, I'd say file a bug on vim-go's issue tracker. I honestly cannot fix a bug I cannot reproduce :)

[mpldr]

You are absolutely correct on that one. I just checked and there is only one binary called gofumpt on my entire computer so this is at least interesting.

[mvdan]

The way gopls uses gofumpt is by statically building with it as a library, so it pins a version on its own. Depending on what gopls version vim-go is using, that gofumpt version might be a bit old, or very old.

Even if the version matches v0.1.1, there's still the question of exactly how gofumpt is run, because it might not match gofumpt file.go.

[moorereason]

My bad. I assumed gopls was using the gofumpt binary. I'm using vim-go (HEAD) with gopls v0.6.11 which has pinned gofumpt v0.1.1.

[mpldr]

@moorereason you can just set let g:go_fmt_command = "gofumpt" instead of what the documentation said, and you're good to go

[moorereason]

Fixed upstream in vim-go.