mvdan / gofumpt

A stricter gofmt
https://pkg.go.dev/mvdan.cc/gofumpt
BSD 3-Clause "New" or "Revised" License
3.15k stars 110 forks source link

Update Helix editor config #274

Closed rsjethani closed 8 months ago

rsjethani commented 1 year ago

Helix editor version 23.10 changes the way language servers are configured. See https://helix-editor.com/news/release-23-10-highlights.

mvdan commented 1 year ago

Do you mean with Helix 23.05, or master? It seems like the config format changed with multi-lsp support: https://github.com/helix-editor/helix/commit/71551d395b4e47804df2d8ecea99e34dbbf16157

I think we want to document what works with stable, not the latest development version. And, as of 23.05, I still see this in the default languages file:

[[language]]
name = "go"
scope = "source.go"
injection-regex = "go"
file-types = ["go"]
roots = ["go.work", "go.mod"]
auto-format = true
comment-token = "//"
language-server = { command = "gopls" }
# TODO: gopls needs utf-8 offsets?
indent = { tab-width = 4, unit = "\t" }

I'm more than happy to merge once Helix does another release, though. Hopefully soon.

rsjethani commented 1 year ago

Ohh yes! you are right @mvdan. I completely ignored the fact that I am using development version :laughing:

Sure lets merge later as you suggested. Thanks!

rsjethani commented 1 year ago

I will update description and general PR tone to be a normal update rather than a bug fix once Helix version is out.

mvdan commented 8 months ago

The release is finally out :) Could you please double check that this config works with it, and update the commit message to explain that the release changed the config format?

rsjethani commented 8 months ago

@mvdan done!